Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly handle RESELECT_REQUESTED state and clearing point2pointipam #1562

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

denis-tingaikin
Copy link
Member

@denis-tingaikin denis-tingaikin commented Dec 11, 2023

Description

Issue link

Related to networkservicemesh/cmd-forwarder-vpp#664

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@774304c). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1562   +/-   ##
=======================================
  Coverage        ?   67.21%           
=======================================
  Files           ?      260           
  Lines           ?    12332           
  Branches        ?        0           
=======================================
  Hits            ?     8289           
  Misses          ?     3520           
  Partials        ?      523           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@glazychev-art glazychev-art merged commit 821b4bc into main Dec 11, 2023
17 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Dec 11, 2023
…k@main

PR link: networkservicemesh/sdk#1562

Commit: 821b4bc
Author: Denis Tingaikin
Date: 2023-12-11 14:03:41 +0300
Message:
  - fix: Correctly handle RESELECT_REQUESTED state and clearing point2pointipam (#1562)
* fix issue networkservicemesh/cmd-forwarder-vpp#664

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix ci issues

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Dec 11, 2023
…k@main

PR link: networkservicemesh/sdk#1562

Commit: 821b4bc
Author: Denis Tingaikin
Date: 2023-12-11 14:03:41 +0300
Message:
  - fix: Correctly handle RESELECT_REQUESTED state and clearing point2pointipam (#1562)
* fix issue networkservicemesh/cmd-forwarder-vpp#664

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix ci issues

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Dec 11, 2023
…k@main

PR link: networkservicemesh/sdk#1562

Commit: 821b4bc
Author: Denis Tingaikin
Date: 2023-12-11 14:03:41 +0300
Message:
  - fix: Correctly handle RESELECT_REQUESTED state and clearing point2pointipam (#1562)
* fix issue networkservicemesh/cmd-forwarder-vpp#664

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix ci issues

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Dec 11, 2023
…k@main

PR link: networkservicemesh/sdk#1562

Commit: 821b4bc
Author: Denis Tingaikin
Date: 2023-12-11 14:03:41 +0300
Message:
  - fix: Correctly handle RESELECT_REQUESTED state and clearing point2pointipam (#1562)
* fix issue networkservicemesh/cmd-forwarder-vpp#664

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix ci issues

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Dec 11, 2023
…k@main

PR link: networkservicemesh/sdk#1562

Commit: 821b4bc
Author: Denis Tingaikin
Date: 2023-12-11 14:03:41 +0300
Message:
  - fix: Correctly handle RESELECT_REQUESTED state and clearing point2pointipam (#1562)
* fix issue networkservicemesh/cmd-forwarder-vpp#664

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix ci issues

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Dec 11, 2023
…k@main

PR link: networkservicemesh/sdk#1562

Commit: 821b4bc
Author: Denis Tingaikin
Date: 2023-12-11 14:03:41 +0300
Message:
  - fix: Correctly handle RESELECT_REQUESTED state and clearing point2pointipam (#1562)
* fix issue networkservicemesh/cmd-forwarder-vpp#664

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix ci issues

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Dec 11, 2023
…k@main

PR link: networkservicemesh/sdk#1562

Commit: 821b4bc
Author: Denis Tingaikin
Date: 2023-12-11 14:03:41 +0300
Message:
  - fix: Correctly handle RESELECT_REQUESTED state and clearing point2pointipam (#1562)
* fix issue networkservicemesh/cmd-forwarder-vpp#664

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix ci issues

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Dec 11, 2023
…k@main

PR link: networkservicemesh/sdk#1562

Commit: 821b4bc
Author: Denis Tingaikin
Date: 2023-12-11 14:03:41 +0300
Message:
  - fix: Correctly handle RESELECT_REQUESTED state and clearing point2pointipam (#1562)
* fix issue networkservicemesh/cmd-forwarder-vpp#664

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix ci issues

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Dec 11, 2023
…k@main

PR link: networkservicemesh/sdk#1562

Commit: 821b4bc
Author: Denis Tingaikin
Date: 2023-12-11 14:03:41 +0300
Message:
  - fix: Correctly handle RESELECT_REQUESTED state and clearing point2pointipam (#1562)
* fix issue networkservicemesh/cmd-forwarder-vpp#664

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix ci issues

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Dec 11, 2023
…k@main

PR link: networkservicemesh/sdk#1562

Commit: 821b4bc
Author: Denis Tingaikin
Date: 2023-12-11 14:03:41 +0300
Message:
  - fix: Correctly handle RESELECT_REQUESTED state and clearing point2pointipam (#1562)
* fix issue networkservicemesh/cmd-forwarder-vpp#664

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix ci issues

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Dec 11, 2023
…k@main

PR link: networkservicemesh/sdk#1562

Commit: 821b4bc
Author: Denis Tingaikin
Date: 2023-12-11 14:03:41 +0300
Message:
  - fix: Correctly handle RESELECT_REQUESTED state and clearing point2pointipam (#1562)
* fix issue networkservicemesh/cmd-forwarder-vpp#664

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix ci issues

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Dec 11, 2023
…k@main

PR link: networkservicemesh/sdk#1562

Commit: 821b4bc
Author: Denis Tingaikin
Date: 2023-12-11 14:03:41 +0300
Message:
  - fix: Correctly handle RESELECT_REQUESTED state and clearing point2pointipam (#1562)
* fix issue networkservicemesh/cmd-forwarder-vpp#664

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix ci issues

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Dec 11, 2023
…k@main

PR link: networkservicemesh/sdk#1562

Commit: 821b4bc
Author: Denis Tingaikin
Date: 2023-12-11 14:03:41 +0300
Message:
  - fix: Correctly handle RESELECT_REQUESTED state and clearing point2pointipam (#1562)
* fix issue networkservicemesh/cmd-forwarder-vpp#664

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix ci issues

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Dec 11, 2023
…k@main

PR link: networkservicemesh/sdk#1562

Commit: 821b4bc
Author: Denis Tingaikin
Date: 2023-12-11 14:03:41 +0300
Message:
  - fix: Correctly handle RESELECT_REQUESTED state and clearing point2pointipam (#1562)
* fix issue networkservicemesh/cmd-forwarder-vpp#664

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix ci issues

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants