Pass dial timeout as option #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1599 +/- ##
=======================================
Coverage ? 67.24%
=======================================
Files ? 262
Lines ? 12443
Branches ? 0
=======================================
Hits ? 8367
Misses ? 3552
Partials ? 524 ☔ View full report in Codecov by Sentry. |
| @@ -100,4 +110,5 @@ type clientOptions struct { | |||
| nsAdditionalFunctionality []registry.NetworkServiceRegistryClient | |||
| nseAdditionalFunctionality []registry.NetworkServiceEndpointRegistryClient | |||
| dialOptions []grpc.DialOption | |||
| dialTimeout time.Duration | |||
There was a problem hiding this comment.
Can we use a default value for the dialTimeout for the case when dialTimeout is not passed?
There was a problem hiding this comment.
We have default values in the chain element.
sdk/pkg/registry/common/dial/nse_client.go
Line 172 in f5e9a5c
Do you think that additional ones need to be defined?
There was a problem hiding this comment.
As I can see, if WithDialTimeout is not passed to the chains/client then the dial timeout here would be zero:
sdk/pkg/registry/common/dial/nse_client.go
Line 172 in f5e9a5c
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
denis-tingaikin
approved these changes
Mar 25, 2024
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Mar 25, 2024
…k@main PR link: networkservicemesh/sdk#1599 Commit: 368383f Author: Artem Glazychev Date: 2024-03-25 16:45:24 +0700 Message: - Pass dial timeout as option (#1599) * Pass dial timeout as option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-dashboard-backend
that referenced
this pull request
Mar 25, 2024
…k@main PR link: networkservicemesh/sdk#1599 Commit: 368383f Author: Artem Glazychev Date: 2024-03-25 16:45:24 +0700 Message: - Pass dial timeout as option (#1599) * Pass dial timeout as option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Mar 25, 2024
…k@main PR link: networkservicemesh/sdk#1599 Commit: 368383f Author: Artem Glazychev Date: 2024-03-25 16:45:24 +0700 Message: - Pass dial timeout as option (#1599) * Pass dial timeout as option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Mar 25, 2024
…k@main PR link: networkservicemesh/sdk#1599 Commit: 368383f Author: Artem Glazychev Date: 2024-03-25 16:45:24 +0700 Message: - Pass dial timeout as option (#1599) * Pass dial timeout as option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Mar 25, 2024
…k@main PR link: networkservicemesh/sdk#1599 Commit: 368383f Author: Artem Glazychev Date: 2024-03-25 16:45:24 +0700 Message: - Pass dial timeout as option (#1599) * Pass dial timeout as option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Mar 25, 2024
…k@main PR link: networkservicemesh/sdk#1599 Commit: 368383f Author: Artem Glazychev Date: 2024-03-25 16:45:24 +0700 Message: - Pass dial timeout as option (#1599) * Pass dial timeout as option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Mar 25, 2024
…k@main PR link: networkservicemesh/sdk#1599 Commit: 368383f Author: Artem Glazychev Date: 2024-03-25 16:45:24 +0700 Message: - Pass dial timeout as option (#1599) * Pass dial timeout as option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Mar 25, 2024
…k@main PR link: networkservicemesh/sdk#1599 Commit: 368383f Author: Artem Glazychev Date: 2024-03-25 16:45:24 +0700 Message: - Pass dial timeout as option (#1599) * Pass dial timeout as option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Mar 25, 2024
…k@main PR link: networkservicemesh/sdk#1599 Commit: 368383f Author: Artem Glazychev Date: 2024-03-25 16:45:24 +0700 Message: - Pass dial timeout as option (#1599) * Pass dial timeout as option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Mar 25, 2024
…k@main PR link: networkservicemesh/sdk#1599 Commit: 368383f Author: Artem Glazychev Date: 2024-03-25 16:45:24 +0700 Message: - Pass dial timeout as option (#1599) * Pass dial timeout as option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Mar 25, 2024
…k@main PR link: networkservicemesh/sdk#1599 Commit: 368383f Author: Artem Glazychev Date: 2024-03-25 16:45:24 +0700 Message: - Pass dial timeout as option (#1599) * Pass dial timeout as option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Mar 25, 2024
…k@main PR link: networkservicemesh/sdk#1599 Commit: 368383f Author: Artem Glazychev Date: 2024-03-25 16:45:24 +0700 Message: - Pass dial timeout as option (#1599) * Pass dial timeout as option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Mar 25, 2024
…k@main PR link: networkservicemesh/sdk#1599 Commit: 368383f Author: Artem Glazychev Date: 2024-03-25 16:45:24 +0700 Message: - Pass dial timeout as option (#1599) * Pass dial timeout as option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Mar 25, 2024
…k@main PR link: networkservicemesh/sdk#1599 Commit: 368383f Author: Artem Glazychev Date: 2024-03-25 16:45:24 +0700 Message: - Pass dial timeout as option (#1599) * Pass dial timeout as option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Mar 25, 2024
…k@main PR link: networkservicemesh/sdk#1599 Commit: 368383f Author: Artem Glazychev Date: 2024-03-25 16:45:24 +0700 Message: - Pass dial timeout as option (#1599) * Pass dial timeout as option Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Mar 25, 2024
This was referenced Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several options were missed
Issue link
networkservicemesh/deployments-k8s#11372
How Has This Been Tested?
Types of changes