Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kernel interface name generation #1603

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Fix kernel interface name generation #1603

merged 1 commit into from
Mar 27, 2024

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Mar 27, 2024 •
edited
Loading

Description

We need to generate the interface name only if the mechanism doesn't have one.

Issue link

How Has This Been Tested?

  • Modified unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@glazychev-art
Fix kernel interface name generation
71d3161 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@050d53f). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1603   +/-   ##
=======================================
  Coverage        ?   67.45%           
=======================================
  Files           ?      262           
  Lines           ?    12464           
  Branches        ?        0           
=======================================
  Hits            ?     8408           
  Misses          ?     3530           
  Partials        ?      526

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glazychev-art glazychev-art self-assigned this Mar 27, 2024
@denis-tingaikin denis-tingaikin merged commit d6d5c0d into networkservicemesh:main Mar 27, 2024
17 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Mar 27, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c8e1183 
…k@main

PR link: networkservicemesh/sdk#1603

Commit: d6d5c0d
Author: Artem Glazychev
Date: 2024-03-27 19:33:56 +0700
Message:
  - Fix kernel interface name generation (#1603)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Mar 27, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
08e5a3c 
…k@main

PR link: networkservicemesh/sdk#1603

Commit: d6d5c0d
Author: Artem Glazychev
Date: 2024-03-27 19:33:56 +0700
Message:
  - Fix kernel interface name generation (#1603)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Mar 27, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e61bc6e 
…k@main

PR link: networkservicemesh/sdk#1603

Commit: d6d5c0d
Author: Artem Glazychev
Date: 2024-03-27 19:33:56 +0700
Message:
  - Fix kernel interface name generation (#1603)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Mar 27, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3899ba3 
…k@main

PR link: networkservicemesh/sdk#1603

Commit: d6d5c0d
Author: Artem Glazychev
Date: 2024-03-27 19:33:56 +0700
Message:
  - Fix kernel interface name generation (#1603)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Mar 27, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6038ce0 
…k@main

PR link: networkservicemesh/sdk#1603

Commit: d6d5c0d
Author: Artem Glazychev
Date: 2024-03-27 19:33:56 +0700
Message:
  - Fix kernel interface name generation (#1603)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-dashboard-backend that referenced this pull request Mar 27, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2cae1f9 
…k@main

PR link: networkservicemesh/sdk#1603

Commit: d6d5c0d
Author: Artem Glazychev
Date: 2024-03-27 19:33:56 +0700
Message:
  - Fix kernel interface name generation (#1603)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Mar 27, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
995c5fb 
…k@main

PR link: networkservicemesh/sdk#1603

Commit: d6d5c0d
Author: Artem Glazychev
Date: 2024-03-27 19:33:56 +0700
Message:
  - Fix kernel interface name generation (#1603)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Mar 27, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9a1c876 
…k@main

PR link: networkservicemesh/sdk#1603

Commit: d6d5c0d
Author: Artem Glazychev
Date: 2024-03-27 19:33:56 +0700
Message:
  - Fix kernel interface name generation (#1603)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Mar 27, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ce773fd 
…k@main

PR link: networkservicemesh/sdk#1603

Commit: d6d5c0d
Author: Artem Glazychev
Date: 2024-03-27 19:33:56 +0700
Message:
  - Fix kernel interface name generation (#1603)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Mar 27, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
297e85f 
…k@main

PR link: networkservicemesh/sdk#1603

Commit: d6d5c0d
Author: Artem Glazychev
Date: 2024-03-27 19:33:56 +0700
Message:
  - Fix kernel interface name generation (#1603)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Mar 27, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4867ee4 
…k@main

PR link: networkservicemesh/sdk#1603

Commit: d6d5c0d
Author: Artem Glazychev
Date: 2024-03-27 19:33:56 +0700
Message:
  - Fix kernel interface name generation (#1603)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Mar 27, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0d4ef94 
…k@main

PR link: networkservicemesh/sdk#1603

Commit: d6d5c0d
Author: Artem Glazychev
Date: 2024-03-27 19:33:56 +0700
Message:
  - Fix kernel interface name generation (#1603)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Mar 27, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6935d45 
…k@main

PR link: networkservicemesh/sdk#1603

Commit: d6d5c0d
Author: Artem Glazychev
Date: 2024-03-27 19:33:56 +0700
Message:
  - Fix kernel interface name generation (#1603)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Mar 27, 2024
Merged
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Mar 27, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5a67c6b 
…k@main

PR link: networkservicemesh/sdk#1603

Commit: d6d5c0d
Author: Artem Glazychev
Date: 2024-03-27 19:33:56 +0700
Message:
  - Fix kernel interface name generation (#1603)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Mar 27, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
58ca6ce 
…k@main

PR link: networkservicemesh/sdk#1603

Commit: d6d5c0d
Author: Artem Glazychev
Date: 2024-03-27 19:33:56 +0700
Message:
  - Fix kernel interface name generation (#1603)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Mar 27, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 27, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@NikitaSkrynnik NikitaSkrynnik Awaiting requested review from NikitaSkrynnik

Assignees

@glazychev-art glazychev-art

Labels
None yet
Projects
Release v1.13.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glazychev-art @denis-tingaikin