Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.0.4 #268

Merged
merged 12 commits into from
Jun 9, 2022
Merged

Release v3.0.4 #268

merged 12 commits into from
Jun 9, 2022

Conversation

chadell
Copy link
Contributor

@chadell chadell commented Jun 9, 2022

No description provided.

@chadell chadell requested a review from jvanderaa June 9, 2022 14:34
Copy link
Contributor

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question. @chadell

@@ -1,3 +1,3 @@
"""Version number for network_importer."""
__version_info__ = (3, 0, "2")
__version_info__ = (3, 0, "3")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be (3, 0, "4") instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna do a change here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>>> import network_importer
>>> network_importer.__version__
'3.0.4'

check 6d7ac5d

@@ -126,6 +126,9 @@ jobs:
integration_nautobot:
name: "Integration Test - Nautobot"
runs-on: "ubuntu-20.04"
strategy:
matrix:
nautobot-version: ["1.0.3", "1.1.6", "1.2.12", "1.3.1"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for using 1.3.1 instead of say 1.3.5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was the latest version available when the commit was created

@chadell chadell merged commit c85d8fc into main Jun 9, 2022
@chadell chadell deleted the release-v3.0.4 branch June 9, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants