Issue 1556 proposed fix #1562
Merged
Issue 1556 proposed fix #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collin-wicker
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
jvanderaa
requested changes
Nov 17, 2023
| Value PART (\S+) | ||
| Value SERIAL (\S+) | ||
| Value DESCRIPTION (\S+) | ||
| Value CHASSIS_SN (\w+) |
There was a problem hiding this comment.
Suggested change
| Value CHASSIS_SN (\w+) | |
| Value CHASSIS_SERIAL_NUMBER (\w+) |
| Value SERIAL (\S+) | ||
| Value DESCRIPTION (\S+) | ||
| Value CHASSIS_SN (\w+) | ||
| Value CHASSIS_DESC (.*) |
There was a problem hiding this comment.
Suggested change
| Value CHASSIS_DESC (.*) | |
| Value CHASSIS_DESCRIPTION (.*) |
|
I have unabbreviated the value names as requested to make the results more explicit. Please review the latest commit for these changes. |
|
Tests have failed because I forgot to update the names in the test files. I will update the test files and commit. |
jvanderaa
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated juniper_junos_show_chassis_hardware.textfsm and associated test files as proposed fix for issue 1556. With the updates the parsed output contains all item numbers, version number, part numbers, serial numbers, and description for each item listed in the test file command output.