Fix triangles to avoid using is to compare nodes
#7041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice if |
jarrodmillman
approved these changes
Oct 22, 2023
|
There is indeed a rule https://docs.astral.sh/ruff/rules/is-literal/ that should catch this. |
dschult
added a commit
to BrunoBaldissera/networkx
that referenced
this pull request
Oct 23, 2023
* change is not to != * replace another is not
Alex-Markham
pushed a commit
to Alex-Markham/networkx
that referenced
this pull request
Oct 26, 2023
* change is not to != * replace another is not
Closed
jarrodmillman
pushed a commit
that referenced
this pull request
Oct 27, 2023
* change is not to != * replace another is not
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
* change is not to != * replace another is not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7038
Using
n is not nodecompares whether n and node are the same object, not whether they are equal.Thanks to a bug report in #7038 we discovered that the string "46" can sometimes be created twice and not internedso that
n is not nodereturns True even though both are equal to "46".The error occurs in
triangleswhen ensuring that a node in not included in its list of neighbors (ruling out self-loops).nis the neighbor in question andnodeis the node being checked. This only goes to prove that "46" is not always the same object as "46". They are the same object if they are interned.Unfortunately figuring out when interning occurs is quite complicated and it may change. So I could not think of a good test to write for this error. So, this PR just replaces the idiom
n is not nodewithn != nodewhich is really how node comparisons should be written always.I don't think we usually do backports but if we release a 3.2.1 for any reason, we should include this fix. It does not occur in v3.1.