Add new dev:module:detect-composer-dependencies command (netz98 contribution) #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hostep
reviewed
Mar 14, 2022
| protected function configure(): void | ||
| { | ||
| $this->setName('dev:module:detect-composer-dependencies') | ||
| ->addArgument('path', InputArgument::IS_ARRAY, 'Path to modules') |
There was a problem hiding this comment.
Hey @cmuench
This is a great new feature, I've just tried it, out of curiosity, but the first time I executed it I got an error that wasn't very helpful:
$ n98-magerun2.phar dev:module:detect-composer-dependencies
In Finder.php line 614:
You must call one of in() or append() methods before iterating over a Finder.
This was because I didn't check how to execute the command at first, and because the path argument was missing.
It's probably a good idea to mark this argument as required using InputArgument::IS_ARRAY | InputArgument::REQUIRED, no?
Thanks! 🙂
There was a problem hiding this comment.
@hostep Yes, good finding. I will change that.
cmuench
added a commit
to cmuench/n98-magerun2
that referenced
this pull request
Mar 15, 2022
cmuench
added a commit
that referenced
this pull request
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Magerun pull-request check-list:
Summary: Backport of a command used in a netz98 QA suite to migrate modules.
This command scans the code for Composer dependencies and provide a recommendation. It can print only missing dependencies.
Special thanks go to:
Changes proposed in this pull request:
dev:module:detect-composer-dependencies