Fixed flexibility of form element styling. #21
Conversation
| @@ -18,7 +20,7 @@ fieldset { | |||
|
|
|||
| .fieldset { | |||
| padding: $fieldset-padding; | |||
| border: 1px color(grayscale, light) solid; | |||
| border: $fieldset-border-width $fieldset-border-color solid; | |||
There was a problem hiding this comment.
Shouldn't we also make the border type configurable? Or don't you think we'll use solid all the time?
There was a problem hiding this comment.
Meh. We could make that configurable but I cannot actually remember a time where I've used any type other than solid so I very much doubt we will ever need to change it.
There was a problem hiding this comment.
And does it make sense to have two separate variables rather than using one like here: https://github.com/netzstrategen/stim-nepo/pull/14/files#diff-6bba191bec7e48daae347c11ab028ba2R102?
There was a problem hiding this comment.
I've now modified the variable (and the override in stim-nepo on the link above). The most likely value to change project-to-project is the border color so this should be customisable without having to repeat the border-width and border-style properties also.
colourgarden
force-pushed
the
fix/form-styling-tom
branch
from
b1c82f3
to
d9cce87
Compare
Added a few variables as some values need to be overwritten in the STIM NEPO project. As they are general, it's better to make the framework here more flexible than add overrides in the STIM project.