Added CSS properties for global colours and variables. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LucaPipolo I've added a commit to Callum's work to make a couple of necessary changes for it to work in our projects (otherwise we get Gulp errors) and also to bump the version number so we can publish it to npm. Could you take a look please? |
LucaPipolo
approved these changes
Feb 27, 2020
colourgarden
added a commit
that referenced
this pull request
May 14, 2020
Incorrectly removed in #26. Though it is no longer used in Bacon itself, some projects rely on this mixin.
colourgarden
added a commit
that referenced
this pull request
May 14, 2020
Incorrectly removed in #26. Though it is no longer used in Bacon itself, some projects rely on this mixin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Notes
_config.core.scssfile. With this solution; projects that want to use custom properties can just set the SASS variables to custom propertyvar()values and then the essential global colours and variables are made available at::rootc--prefx for colours and theng--prefix for global variables to try and keep the names shorter.