Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pre-computing statistics for each system #111

Merged
merged 8 commits into from
Aug 7, 2019
Merged

Support pre-computing statistics for each system #111

merged 8 commits into from
Aug 7, 2019

Conversation

zdou0830
Copy link
Contributor

No description provided.

@neubig
Copy link
Contributor

neubig commented Jul 22, 2019

Thanks for this! As I was looking through the code, it seemed that this adds a bit of repetitiveness and complexity to the codebase. I wonder if there is a way that we can create a more general wrapper for cached functions that would make this cleaner? If you can't think of a way to do it immediately then this is probably OK as-is, but I think it'd be a nice thing to have. Maybe something like the standard Python lru_cache functionality (although I don't think we could use this as-is).

@zdou0830
Copy link
Contributor Author

Thanks! I will take a look at lru_cache and think more about it!

@zdou0830
Copy link
Contributor Author

zdou0830 commented Aug 4, 2019

I just made the code a little bit cleaner, but I haven't come up with a way to create a more general wrapper yet. Please take a look. Thanks!

@neubig
Copy link
Contributor

neubig commented Aug 7, 2019

Thanks! Looks quite a bit better, I'll merge.

@neubig neubig merged commit 41700d6 into master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants