Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding decoder trainer #53

Merged
merged 65 commits into from
May 13, 2023
Merged

adding decoder trainer #53

merged 65 commits into from
May 13, 2023

Conversation

zhaochenyang20
Copy link
Collaborator

@zhaochenyang20 zhaochenyang20 commented May 10, 2023 •
edited
Loading

Description

All the Seq2Seq models are appropriate for our project, thus I added decoder-only (text-generation) model in our Trainer with new unit tests.

References

Blocked by

@zhaochen20
Merge branch 'main' of github.com:viswavi/prompt2model
f98a478
@zhaochen20
add trainer in base
2be05ee
@zhaochen20
Merge branch 'main' of github.com:viswavi/prompt2model
f426e81
@zhaochen20
Merge branch 'main' into Eren_Trainer
3fe57ef
@zhaochen20
create SimpleTrainer
2921a10
@zhaochen20
Merge branch 'main' of github.com:viswavi/prompt2model
23aa3db
@zhaochen20
Merge branch 'main' into Eren_Trainer
fa2b30c
@zhaochen20
merge main into Trainer
94c9765
@zhaochen20
fix mock trainer
2733e18
@zhaochen20
add new interface
e8af37b
@zhaochen20
refix mock trainer
70e760b
@zhaochen20
Merge branch 'fix_mock_trainer' into Eren_Trainer
ed095e6
@zhaochen20
retrain the final layer
2ca0e31
@zhaochen20
needs more design by now
7dca665
@zhaochen20
needs more design by now
d6bfb78
@zhaochen20
rename transtrainer
9418323
@zhaochen20
Merge branch 'main' of github.com:viswavi/prompt2model
c895817
@zhaochen20
Merge branch 'main' of github.com:viswavi/prompt2model
921e800
@zhaochen20
Merge branch 'main' into Eren_Trainer
fb76a3f
@zhaochen20
Merge branch 'main' of github.com:viswavi/prompt2model
27e3371
@zhaochen20
Merge branch 'main' of github.com:viswavi/prompt2model
2aaa739
@zhaochen20
Merge branch 'main' into Eren_Trainer
0f9ef71
@zhaochen20
rename model id to model name
4fc61bc
@zhaochen20
rename trainer
d017d8b
@zhaochen20
rename ModelTrainer
ca8970e
@zhaochen20
add t5 trainer
7b60bd1
@zhaochen20
add t5 unit test
d4d25d9
@zhaochen20
add failed trainer
57b4abe
@zhaochen20
add failed trainer ver 2
ca56117
@zhaochen20
add loss function
60f4581
viswavi
viswavi requested changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@viswavi viswavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can deduplicate some code between T5 and GPT trainers, since a lot of these are shared. Can we write a common parent class that we can specialize into these two?

prompt2model/model_trainer/GPT.py Outdated Show resolved Hide resolved
tests/model_trainer_test.py Outdated Show resolved Hide resolved
prompt2model/model_trainer/GPT.py Outdated Show resolved Hide resolved
prompt2model/model_trainer/GPT.py Outdated Show resolved Hide resolved
prompt2model/model_trainer/GPT.py Outdated Show resolved Hide resolved
prompt2model/model_trainer/GPT.py Outdated Show resolved Hide resolved
prompt2model/model_trainer/GPT.py Outdated Show resolved Hide resolved
@zhaochenyang20 zhaochenyang20 changed the base branch from Eren_Trainer to main May 11, 2023 07:04
viswavi
viswavi requested changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@viswavi viswavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are looking good! My suggested changes were all concerning:

  1. breaking up a test case
  2. renaming a class
  3. fixing comments/docstrings.

Otherwise should be able to merge soon!

prompt2model/model_trainer/base.py Outdated Show resolved Hide resolved
prompt2model/model_trainer/base.py Outdated Show resolved Hide resolved
prompt2model/model_trainer/base.py Outdated Show resolved Hide resolved
prompt2model/model_trainer/base.py Outdated Show resolved Hide resolved
prompt2model/model_trainer/base.py Outdated Show resolved Hide resolved
prompt2model/model_trainer/base.py Outdated Show resolved Hide resolved
tests/model_trainer_test.py Outdated Show resolved Hide resolved
tests/model_trainer_test.py Outdated Show resolved Hide resolved
viswavi
viswavi approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@viswavi viswavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaochenyang20 zhaochenyang20 merged commit 67135d6 into main May 13, 2023
@zhaochenyang20 zhaochenyang20 deleted the Eren_decoder_trainer branch May 13, 2023 00:42
@zhaochenyang20 zhaochenyang20 mentioned this pull request May 13, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viswavi viswavi viswavi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhaochenyang20 @viswavi @zhaochen20