Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak and improve upload progress #2523

Merged
merged 3 commits into from
Jan 14, 2022
Merged

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Jan 12, 2022

Closes #2504

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #2523 (8adc079) into master (46f6e79) will decrease coverage by 0.03%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2523      +/-   ##
==========================================
- Coverage   85.47%   85.43%   -0.04%     
==========================================
  Files          70       70              
  Lines       11794    11826      +32     
  Branches     2293     2295       +2     
==========================================
+ Hits        10081    10104      +23     
- Misses       1332     1338       +6     
- Partials      381      384       +3     
Impacted Files Coverage Δ
neuro-sdk/src/neuro_sdk/_bucket_base.py 86.25% <ø> (ø)
neuro-sdk/src/neuro_sdk/_s3_bucket_provider.py 91.40% <85.71%> (+0.40%) ⬆️
neuro-sdk/src/neuro_sdk/_file_utils.py 89.83% <95.45%> (-0.21%) ⬇️
neuro-sdk/src/neuro_sdk/_buckets.py 85.67% <100.00%> (ø)
neuro-sdk/src/neuro_sdk/_core.py 92.41% <0.00%> (-2.07%) ⬇️
neuro-cli/src/neuro_cli/asyncio_utils.py 77.48% <0.00%> (-0.67%) ⬇️
neuro-cli/src/neuro_cli/main.py 61.53% <0.00%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46f6e79...8adc079. Read the comment docs.

@asvetlov asvetlov merged commit 74a684e into master Jan 14, 2022
@asvetlov asvetlov deleted the rs/improve-blob-uploads branch January 14, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

neuro blob cp memory leak
2 participants