Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query response should include total number of subjects in a dataset #216

Closed
2 tasks done
Tracked by #59
surchs opened this issue Nov 7, 2023 · 5 comments · Fixed by #223
Closed
2 tasks done
Tracked by #59

Query response should include total number of subjects in a dataset #216

surchs opened this issue Nov 7, 2023 · 5 comments · Fixed by #223
Assignees
@alyssadai
Labels
feat:add The first minimal viable change that implements a new functionality. type:feature Effort to deliver new features, feature changes & improvements

Comments

@surchs
Copy link
Contributor

surchs commented Nov 7, 2023 •
edited by alyssadai
Loading

The query response should include the total number of unique subjects in a dataset so that the user knows what subset their query has matched. This will also help us make our sample-level search more easy to visualize on the graphical query tool

  • dataset level response object has a key for total_number_subjects or similar with a int value equal to # of subjects in dataset
  • add logic for a separate query to graph for total # subjects in matching datasets
@surchs surchs added feat:add The first minimal viable change that implements a new functionality. type:feature Effort to deliver new features, feature changes & improvements labels Nov 7, 2023
This was referenced Nov 7, 2023
Closed
Closed
Closed
@rmanaem
Copy link
Collaborator

rmanaem commented Nov 8, 2023

I feel like this issue should be addressed in the node api first and then changes should be made in the federation api. wdyt @alyssadai ?

@alyssadai
Copy link
Contributor

agree!

@alyssadai alyssadai added the flag:schedule Flag issue that should go on the roadmap or backlog. label Nov 9, 2023
@alyssadai alyssadai transferred this issue from neurobagel/federation-api Nov 9, 2023
@alyssadai alyssadai removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Nov 9, 2023
@surchs
Copy link
Contributor Author

surchs commented Nov 13, 2023

@neurobagel/dev anything else to be done than the checkbox in the spec?

@alyssadai
Copy link
Contributor

Nope, I think that's all!

@alyssadai alyssadai self-assigned this Nov 13, 2023
@alyssadai
Copy link
Contributor

Blocked by #202 for dev experience reasons

@alyssadai alyssadai mentioned this issue Nov 14, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssadai alyssadai

Labels
feat:add The first minimal viable change that implements a new functionality. type:feature Effort to deliver new features, feature changes & improvements
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ENH] Return dataset sizes in query response neurobagel/api
3 participants
@surchs @alyssadai @rmanaem