-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] Make session count names clearer in query response #282
Conversation
Pull Request Test Coverage Report for Build 8083459842Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @alyssadai!
I have not tested this query myself, and that makes me think it'd be nice to have at least one test that would do that for us automatically.
🧑🍳
Co-authored-by: Sebastian Urchs <surchs@users.noreply.github.com>
🚀 PR was released in |
num_{imaging,phenotypic}_sessions
to benum_matching_{imaging,phenotypic}_sessions
#271Changes proposed in this pull request:
Note:
min_num_{phenotypic,imaging}_sessions
still makes more sense in a query)Checklist
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see https://neurobagel.org/contributing/pull_requests for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: