Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write integration test that confirms the SPARQL query works against a current graph #283

Closed
surchs opened this issue Feb 28, 2024 · 1 comment · Fixed by #357
Closed
Assignees
Labels
maint:process Improvement to internal processes released This issue/pull request has been released. someday Not a priority right now, but we want to keep this around to think or discuss more. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs

Comments

@surchs
Copy link
Contributor

surchs commented Feb 28, 2024

#282 is a good example of a PR that looks good but to be completely sure a reviewer would have to

  • clone the PR branch
  • spin up a local graph
  • configure the graph (although that is easier now with [ENH] Add GraphDB setup script recipes#19)
  • put data into the local graph
  • either spin up the local PR branch directly and connect to the Graph by hand OR
  • build a new docker image from the local PR branch, edit the docker-compose.yml and then spin up the local branch API with the graph

That's silly work and a bot should do it. As part of a test. We should be most of the way there already, but the rest is probably still a good bit of work.

The crucial part of the issue entails testing that the query template returns expected results, rather than the content of the query string itself. Specifically, this may requiring construct test queries, and then asserting over responses from the graph.

This would help catch issues such as:

@surchs surchs added type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs maint:process Improvement to internal processes someday Not a priority right now, but we want to keep this around to think or discuss more. labels Feb 28, 2024
@alyssadai alyssadai added the flag:schedule Flag issue that should go on the roadmap or backlog. label Oct 10, 2024
@rmanaem rmanaem removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Oct 15, 2024
Copy link

🚀 Issue was released in v0.4.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maint:process Improvement to internal processes released This issue/pull request has been released. someday Not a priority right now, but we want to keep this around to think or discuss more. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs
Projects
Status: Review - Done
Development

Successfully merging a pull request may close this issue.

3 participants