Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review #2 #7

Closed
pbellec opened this issue Jun 24, 2019 · 4 comments
Closed

review #2 #7

pbellec opened this issue Jun 24, 2019 · 4 comments
Assignees

Comments

@pbellec
Copy link
Member

pbellec commented Jun 24, 2019

Thank you @martinagvilas for agreeing to review this submission. You can find our guidelines for review here. When your review is completed, please leave a comment on this issue saying so. If there are unresolved issues that you believe to be impeding the acceptance of the repository, please list them here.

@pbellec
Copy link
Member Author

pbellec commented Jun 25, 2019

currently issues #8 #9 #10 and #11 have been identified through this review.

@pbellec
Copy link
Member Author

pbellec commented Jul 3, 2019

@martinagvilas please check out this pull request #12 and let @glatard know if this addresses all of your concern.

@martinagvilas
Copy link
Collaborator

@glatard has addressed all my concerns and I believe this tutorial provides a clear and concise overview of boutiques, and puts into evidence the advantages of using this framework. It is easy to read, it is logically organized into relevant sections, and it is of appropriate length.

Thank you for giving me the opportunity to review it.

@pbellec
Copy link
Member Author

pbellec commented Jul 4, 2019

Thanks a lot @martinagvilas for taking the time to review this work, and thanks @glatard for addressing all the issues in a timely fashion. I am closing this review.

@pbellec pbellec closed this as completed Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants