Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mswin readline legacy code #1396

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Remove mswin readline legacy code #1396

merged 1 commit into from
Aug 4, 2021

Conversation

alkino
Copy link
Member

@alkino alkino commented Aug 4, 2021

This copy of readline seems unused today?

@codecov-commenter
Copy link

Codecov Report

Merging #1396 (d3754d3) into master (b4da443) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1396      +/-   ##
==========================================
+ Coverage   33.07%   33.15%   +0.08%     
==========================================
  Files         569      569              
  Lines      108959   108959              
==========================================
+ Hits        36037    36125      +88     
+ Misses      72922    72834      -88     
Impacted Files Coverage Δ
src/parallel/bbs.cpp 64.78% <0.00%> (+1.87%) ⬆️
src/parallel/bbssrv2mpi.cpp 54.59% <0.00%> (+3.44%) ⬆️
src/nrnmpi/bbsmpipack.cpp 86.44% <0.00%> (+12.42%) ⬆️
src/parallel/bbsclimpi.cpp 51.29% <0.00%> (+21.42%) ⬆️
src/parallel/bbssrvmpi.cpp 43.03% <0.00%> (+29.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4da443...d3754d3. Read the comment docs.

@alkino alkino requested a review from nrnhines August 4, 2021 11:10
@alexsavulescu alexsavulescu changed the title Remove copy of readline Remove mswin readline legacy code Aug 4, 2021
@nrnhines nrnhines merged commit fedfe15 into master Aug 4, 2021
@alkino alkino deleted the remove_readline_2 branch August 4, 2021 12:54
@alexsavulescu alexsavulescu mentioned this pull request Mar 22, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants