Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid segfault if error during construction of POINT_PROCESS #1627

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

nrnhines
Copy link
Member

Includes test that the error is recoverable. Errors happen if there is no section or if the position parameter is out of range.

Closes #1625

@codecov-commenter
Copy link

Codecov Report

Merging #1627 (b6f1339) into master (d5f6139) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1627      +/-   ##
==========================================
- Coverage   45.19%   45.16%   -0.04%     
==========================================
  Files         551      551              
  Lines      111183   111184       +1     
==========================================
- Hits        50253    50212      -41     
- Misses      60930    60972      +42     
Impacted Files Coverage Δ
src/nrnoc/point.cpp 79.61% <100.00%> (+0.09%) ⬆️
src/nrnmpi/bbsmpipack.cpp 82.56% <0.00%> (-10.77%) ⬇️
src/parallel/bbsclimpi.cpp 50.00% <0.00%> (-8.14%) ⬇️
src/parallel/bbssrvmpi.cpp 42.16% <0.00%> (-6.03%) ⬇️
src/parallel/bbs.cpp 74.26% <0.00%> (-1.69%) ⬇️
src/nrnoc/cabcode.cpp 71.52% <0.00%> (+0.08%) ⬆️
src/oc/code2.cpp 52.79% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5f6139...b6f1339. Read the comment docs.

@alexsavulescu alexsavulescu merged commit 5cbcfa2 into master Feb 16, 2022
@alexsavulescu alexsavulescu deleted the hines/nosection-bug branch February 16, 2022 11:19
@alexsavulescu alexsavulescu mentioned this pull request Mar 22, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling h.SEClamp with an int SegFaults
3 participants