Bugfix for rxd reactions involving rxd parameters. #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjhn
added a commit
to adamjhn/netpyne
that referenced
this pull request
Jul 25, 2022
Parameters need to be added before reactions. Parameter names should probably default to the key (in the same way as species and states). Additional storing the hObj for rxd region geometry in netParams causing problems saving netParams, becuase the geometry objects are not JSON serializable. Fix depends on NEURON pull request; neuronsimulator/nrn#1933
|
✔️ 7475dd5 -> Azure artifacts URL |
|
✔️ f9d25ba -> Azure artifacts URL |
ramcdougal
reviewed
Aug 24, 2022
Codecov Report
@@ Coverage Diff @@
## master #1933 +/- ##
==========================================
+ Coverage 46.47% 46.50% +0.03%
==========================================
Files 526 526
Lines 119212 119216 +4
==========================================
+ Hits 55401 55439 +38
+ Misses 63811 63777 -34
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
✔️ 92c0990 -> Azure artifacts URL |
ramcdougal
approved these changes
Aug 24, 2022
alexsavulescu
pushed a commit
that referenced
this pull request
Dec 7, 2022
alexsavulescu
pushed a commit
that referenced
this pull request
Dec 15, 2022
alexsavulescu
pushed a commit
that referenced
this pull request
Dec 15, 2022
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.