Build src/gnu as its own library #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ 2b4a3a7 -> Azure artifacts URL |
|
✔️ d1b749d -> Azure artifacts URL |
Codecov Report
@@ Coverage Diff @@
## master #2391 +/- ##
==========================================
- Coverage 60.19% 60.18% -0.01%
==========================================
Files 641 627 -14
Lines 121184 121007 -177
==========================================
- Hits 72942 72830 -112
+ Misses 48242 48177 -65
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
✔️ 4fc6ad8 -> Azure artifacts URL |
|
✔️ 09f0948 -> Azure artifacts URL |
nrnhines
reviewed
Jun 19, 2023
|
No, my purpose is to break the nrniv monolith, and separate noodles. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alexsavulescu
approved these changes
Jun 19, 2023
Just some refactoring. Ultimate goal is still to drop gnu folder. |
|
✔️ 03254ba -> Azure artifacts URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the directory src/gnu produce now a standalone static library that is linked to nrniv.