BBS: pickle is now a std::vector<char>

[alkino]

No description provided.

[azure-pipelines]

✔️ 9e74c50 -> Azure artifacts URL

[azure-pipelines]

✔️ 9e74c50 -> Azure artifacts URL

[azure-pipelines]

✔️ 721a81b -> Azure artifacts URL

[codecov]

Codecov Report

Attention: Patch coverage is 82.67717% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 67.17%. Comparing base (0a7b890) to head (8f3626e).

❗ Current head 8f3626e differs from pull request most recent head c7309d4. Consider uploading reports for the commit c7309d4 to get more accurate results

Files	Patch %	Lines
src/parallel/ocbbs.cpp	55.55%	16 Missing ⚠️
src/parallel/bbs.cpp	63.63%	4 Missing ⚠️
src/nrnpython/nrnpy_p2h.cpp	96.07%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2822      +/-   ##
==========================================
- Coverage   67.17%   67.17%   -0.01%     
==========================================
  Files         563      564       +1     
  Lines      104283   104256      -27     
==========================================
- Hits        70056    70033      -23     
+ Misses      34227    34223       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[azure-pipelines]

✔️ dd941f7 -> Azure artifacts URL

[1uc]

To my understanding this PR changes the following:

• char* is replaced with a std::vector<char>. The choice is because MessageItem needs to destinguish between a pickle (std::vector<char>) and a string (std::string).

This enables a few simplifications, e.g. the size is returned as part of the std::vector. There's one occurrence of where we introduce an additional copy.

[azure-pipelines]

✔️ be83cff -> Azure artifacts URL

[azure-pipelines]

✔️ 8f3626e -> Azure artifacts URL

[sonarcloud]

Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
4.1% Duplication on New Code

See analysis details on SonarCloud

[azure-pipelines]

✔️ c7309d4 -> Azure artifacts URL

[bbpbuildbot]

Logfiles from GitLab pipeline #209447 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
• ✅ spack_setup
• ✅ build:nmodl
• ✅ build:neuron:nmodl:intel:legacy
• ✅ build:neuron:nmodl:intel:shared
• ✅ build:neuron:nmodl:nvhpc:acc:legacy
• ✅ build:neuron:nmodl:nvhpc:acc:shared
• ✅ build:neuron:nmodl:nvhpc:omp:legacy
• ✅ build:neuron:nmodl:nvhpc:omp
• ✅ test:neuron:nmodl:intel:legacy
• ✅ test:neuron:nmodl:intel:shared
• ✅ test:neuron:nmodl:nvhpc:acc:legacy
• ✅ test:neuron:nmodl:nvhpc:acc:shared
• ✅ test:neuron:nmodl:nvhpc:omp:legacy
• ✅ test:neuron:nmodl:nvhpc:omp