Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up DOS ifdef #2872

Merged
merged 3 commits into from
May 7, 2024
Merged

Clean up DOS ifdef #2872

merged 3 commits into from
May 7, 2024

Conversation

mgeplf
Copy link
Collaborator

@mgeplf mgeplf commented May 6, 2024

No description provided.

@mgeplf
Copy link
Collaborator Author

mgeplf commented May 6, 2024

From what I can tell, the DOS define wasn't being defined anywhere, and I couldn't find a compiler that defines it automatically.

I think it would be worth having @nrnhines to have a look, since he knows the history, and what this was originally intended for.

Copy link

sonarcloud bot commented May 6, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.19%. Comparing base (d99cbb5) to head (38b8867).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2872      +/-   ##
==========================================
+ Coverage   67.18%   67.19%   +0.01%     
==========================================
  Files         564      563       -1     
  Lines      104268   104244      -24     
==========================================
- Hits        70053    70048       -5     
+ Misses      34215    34196      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nrnhines nrnhines merged commit cb09926 into neuronsimulator:master May 7, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants