Use a shortcut for globals to reduce time

[alkino]

No description provided.

[sonarcloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
12.9% Duplication on New Code

See analysis details on SonarCloud

[azure-pipelines]

✔️ 7717ba3 -> Azure artifacts URL

[azure-pipelines]

✔️ 1d48abc -> Azure artifacts URL

[github-actions]

NEURON ModelDB CI: launching for 1d48abc via its drop url

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.22%. Comparing base (f1c6197) to head (1d48abc).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2909      +/-   ##
==========================================
- Coverage   67.22%   67.22%   -0.01%     
==========================================
  Files         569      569              
  Lines      104694   104714      +20     
==========================================
+ Hits        70381    70390       +9     
- Misses      34313    34324      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bbpbuildbot]

Logfiles from GitLab pipeline #217482 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
• ✅ spack_setup
• ✅ build:nmodl
• ✅ build:neuron:nmodl:intel:legacy
• ✅ build:neuron:nmodl:intel:shared
• ✅ build:neuron:nmodl:nvhpc:acc:legacy
• ✅ build:neuron:nmodl:nvhpc:acc:shared
• ✅ build:neuron:nmodl:nvhpc:omp:legacy
• ✅ build:neuron:nmodl:nvhpc:omp
• ✅ test:neuron:nmodl:intel:legacy
• ✅ test:neuron:nmodl:intel:shared
• ✅ test:neuron:nmodl:nvhpc:acc:legacy
• ✅ test:neuron:nmodl:nvhpc:acc:shared
• ✅ test:neuron:nmodl:nvhpc:omp:legacy
• ✅ test:neuron:nmodl:nvhpc:omp

[github-actions]

NEURON ModelDB CI: 1d48abc -> download reports from here

[1uc]

From my side this looks very good and it seems ModelDB CI is passing too.

There's one question about bbcore_{read,write}: do those ever need to access thread variables?

Maybe @pramodk or @nrnhines want to try if the combined effect of this PR and #2914 solves the performance issue reported in #2787.

[alkino]

GLOBAL in hh.mod:
master:

nt	 cache0	          cache1
1	 10.6936          11.6262
2	 6.75487          6.81813
4	 5.42909          5.77618
8	 4.5747           4.37193

this PR:

nt	 cache0	           cache1
1	 5.38534           5.39634
2	 2.81755           2.82948
4	 1.9551            1.83342
8	 1.43766           1.50557

[pramodk]

LGTM

(questions were already clarified offline)