Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport numpy pinning to 8.2 #2920

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Backport numpy pinning to 8.2 #2920

merged 4 commits into from
Jun 20, 2024

Conversation

JCGoran
Copy link
Contributor

@JCGoran JCGoran commented Jun 18, 2024

Backports of #2916 and #2919 to release 8.2. Required to make neuronsimulator/nrn-build-ci#69 green since the testing of the stable version actually checks out the testing scripts on that branch, which doesn't have the pinning.

Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope we will have numpy 2 compatbility soon! But until then....LGTM! :)

@JCGoran
Copy link
Contributor Author

JCGoran commented Jun 19, 2024

Due to the error reported by delocate, I also bumped the version of MACOSX_DEPLOYMENT_TARGET to 10.15; I don't know if this will break any compatibility though (10.15 came out in 2019 and it's been EOL since Nov 2022 so I assumed it's safe to bump it).

Copy link

✔️ dd86335 -> Azure artifacts URL

Copy link

sonarcloud bot commented Jun 20, 2024

Copy link

✔️ 8595546 -> Azure artifacts URL

@JCGoran JCGoran merged commit 1ee4fd5 into release/8.2 Jun 20, 2024
37 checks passed
@JCGoran JCGoran deleted the jelic/backport_numpy branch June 20, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants