Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate nbconvert target #679

Merged
merged 2 commits into from
Jul 24, 2020
Merged

separate nbconvert target #679

merged 2 commits into from
Jul 24, 2020

Conversation

alexsavulescu
Copy link
Member

Remove CMake prepare_docs dependency for sphinx.
By doing so, make sphinx will work faster in case of local re-runs.

nrnhines
nrnhines approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful. I take it that full make dependency processing for documentation is a much larger project.

@alexsavulescu
Copy link
Member Author

Very helpful. I take it that full make dependency processing for documentation is a much larger project.

Indeed. Alternative would be to use setup.py but I remember having lots of issues there.

@alexsavulescu
Copy link
Member Author

Also, there are sphinx libraries for jupyter notebooks (nbpshinx ) and for doxygen (breathe + ehxale) but they are not production ready yet. That would simply things a lot and maybe just have one CMake target or leverage docs through setup.py

pramodk
pramodk approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you were too fast alex to implement this! thanks! :)

@nrnhines nrnhines merged commit 1f8b2f8 into master Jul 24, 2020
@nrnhines nrnhines deleted the separate_nbtarget branch July 24, 2020 22:46
@alexsavulescu alexsavulescu mentioned this pull request Dec 8, 2020
Closed
@alexsavulescu alexsavulescu mentioned this pull request Apr 26, 2021
Closed
olupton pushed a commit that referenced this pull request Dec 7, 2022
@pramodk
Fixed for watch statements codegen, global and NetSendBuffer_t variab…
6678d8e 
…les update on CPU/GPU (#710)

* fixed for watch statements, global variable on GPU
* fixed watch statement code generation described in #679
* fixed global variable update to gpu descrbed in #678
* fixed atomic capture for net_send buffer
* fixed for watch test on GPU
     - Initial block was missing net_send_buffering related codegen
       when net_send was used
     - fix indentation with watch if-else statements
     - net_send_buffer updates from host & device missing
     - net_receieve_buffer code was out of place
* Incorporate BlueBrain/mod2c/pull/63
* Fix CVF CI: INITIAL block shouldn't be executed on ISPC backend
   when mod file uses net_send/net_event method. This is because they
   contain non-compatible code for event buffering used for GPU.
* Fix the weight_index argument for net_send_buffering()
   generated for net_send() call in INITIAL block.
   - See analysis in BlueBrain/nmodl#680

Closes #679, closes #678, closes #675, closes #680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrnhines nrnhines nrnhines approved these changes

@pramodk pramodk pramodk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexsavulescu @pramodk @nrnhines