Bug fix for library name extensions #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- python libraries like /usr/lib64/libpython2.7.so was detected
as libpython2 (instead of libpython2.7)
- this was becuase NAME_WE returns file name without entire longest
extension
- while extracting library name we want to remove last extension only
i.e. `.so` or `.a`. And hence we have to use NAME_WLE
This fixes issue while building NEURON on Marconi100 on Cineca.
See https://cmake.org/cmake/help/latest/command/get_filename_component.html
nrnhines
approved these changes
Jul 30, 2020
alexsavulescu
approved these changes
Jul 30, 2020
nrnhines
added a commit
that referenced
this pull request
Nov 14, 2020
* Use cmake 3.8.2 for CI. * exit travis if actual cmake not desired cmake version * Remove use of NAME_WLE with get_filename_component (CMake < 3.14) - #687 introduced use of NAME_WLE but it's only available in CMake v 3.14 - use NAME with regex pattern to do the same fixes #700 Co-authored-by: Pramod Kumbhar <pramod.kumbhar@epfl.ch>
nrnhines
pushed a commit
that referenced
this pull request
Dec 8, 2020
- python libraries like /usr/lib64/libpython2.7.so was detected
as libpython2 (instead of libpython2.7)
- this was becuase NAME_WE returns file name without entire longest
extension
- while extracting library name we want to remove last extension only
i.e. `.so` or `.a`. And hence we have to use NAME_WLE
This fixes issue while building NEURON on Marconi100 on Cineca.
See https://cmake.org/cmake/help/latest/command/get_filename_component.html
alexsavulescu
pushed a commit
that referenced
this pull request
Dec 9, 2020
* Use cmake 3.8.2 for CI. * exit travis if actual cmake not desired cmake version * Remove use of NAME_WLE with get_filename_component (CMake < 3.14) - #687 introduced use of NAME_WLE but it's only available in CMake v 3.14 - use NAME with regex pattern to do the same fixes #700 Co-authored-by: Pramod Kumbhar <pramod.kumbhar@epfl.ch>
nrnhines
pushed a commit
that referenced
this pull request
Dec 10, 2020
- python libraries like /usr/lib64/libpython2.7.so was detected
as libpython2 (instead of libpython2.7)
- this was becuase NAME_WE returns file name without entire longest
extension
- while extracting library name we want to remove last extension only
i.e. `.so` or `.a`. And hence we have to use NAME_WLE
This fixes issue while building NEURON on Marconi100 on Cineca.
See https://cmake.org/cmake/help/latest/command/get_filename_component.html
nrnhines
added a commit
that referenced
this pull request
Dec 10, 2020
* Use cmake 3.8.2 for CI. * exit travis if actual cmake not desired cmake version * Remove use of NAME_WLE with get_filename_component (CMake < 3.14) - #687 introduced use of NAME_WLE but it's only available in CMake v 3.14 - use NAME with regex pattern to do the same fixes #700 Co-authored-by: Pramod Kumbhar <pramod.kumbhar@epfl.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as libpython2 (instead of libpython2.7)
extension
i.e.
.soor.a. And hence we have to use NAME_WLEThis fixes issue while building NEURON on Marconi100 on Cineca.
See https://cmake.org/cmake/help/latest/command/get_filename_component.html
Examples before this patch: note the
libpython2vslibpython2.7which causes issue with link time when we usenrnivmodl:With this PR
fyi: @ferdonline