compute_dprime function has n_hits, n_miss, n_cr, n_fa hard coded

[jonathanicholas]

Hi--Thanks for developing this repo. I wanted to compare my own dprime/aprime calculations with ones from other repos and found the following:

NeuroKit.py/neurokit/statistics/routines.py

Line 81 in 867655f

n_Hit = 9

Should be an easy fix. Thanks!

[DominiqueMakowski]

Indeed a bug that must have passed through the tests! thanks for noticing!!
Should be fixed on master now

[jonathanicholas]

No worries! It also looks like there's a bug in the dprime calculation where hit_rate_adjusted is subtracted from hit_rate_adjusted rather than fa_rate_adjusted

NeuroKit.py/neurokit/statistics/routines.py

Line 97 in 867655f

dprime = scipy.stats.norm.ppf(hit_rate_adjusted) - scipy.stats.norm.ppf(hit_rate_adjusted)

[DominiqueMakowski]

Damn! lucky you're here :)

[jonathanicholas]

hah, no problem! Gonna close this issue now.