Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/builder/:id route needs to return 404 if it id ends up not existing. #484

Closed
rwblair opened this issue Feb 5, 2019 · 0 comments · Fixed by #566
Closed

/builder/:id route needs to return 404 if it id ends up not existing. #484

rwblair opened this issue Feb 5, 2019 · 0 comments · Fixed by #566
Projects

Comments

@rwblair
Copy link
Collaborator

rwblair commented Feb 5, 2019

As of now it will just attempt to display the Overview tab. Users hopefully wont be putting garbage in that url, but if we hear from the api that the provided api we need to bail out of the builder component and display 404.tsx

@adelavega adelavega added this to To Do (Frontend) in 0.9 via automation Mar 27, 2019
@rwblair rwblair moved this from To Do (Frontend) to In Progress in 0.9 May 14, 2019
rwblair added a commit that referenced this issue May 14, 2019
…nalysis

function accordingly. Fixes #555

Disable next button on contrast tab if no contrasts present. Never set
flag to generate reports if no contrasts exist. Fixes #537

Have analyses names line break if too long. Fixes #562

Non existant analysis IDs will now redirect to /builder/. Fixes #484

on error codes 400 and above do not attempt to parse response as json, just
return status code so component can figure out what it wants to do.
Fixes #527
0.9 automation moved this from In Progress to Done May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.9
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants