Fixes for frontend regressions. #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nalysis function accordingly. Fixes #555 Disable next button on contrast tab if no contrasts present. Never set flag to generate reports if no contrasts exist. Fixes #537 Have analyses names line break if too long. Fixes #562 Non existant analysis IDs will now redirect to /builder/. Fixes #484 on error codes 400 and above do not attempt to parse response as json, just return status code so component can figure out what it wants to do. Fixes #527
|
@adelavega I tested this code compiled and still wasn't seeing #556. Will address it in a future pr since it might take more investigation. |
Codecov Report
@@ Coverage Diff @@
## master #566 +/- ##
==========================================
+ Coverage 84.59% 84.68% +0.08%
==========================================
Files 39 39
Lines 1675 1724 +49
==========================================
+ Hits 1417 1460 +43
- Misses 258 264 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datasets were moved to props of builder out of state, updated update analysis
function accordingly. Fixes #555
Disable next button on contrast tab if no contrasts present. Never set
flag to generate reports if no contrasts exist. Fixes #537
Have analyses names line break if too long. Fixes #562
Non existent analysis IDs will now redirect to /builder/. Fixes #484
on error codes 400 and above do not attempt to parse response as json, just
return status code so component can figure out what it wants to do.
Fixes #527