Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report is generated prior to contrast creation #537

Closed
adelavega opened this issue Apr 3, 2019 · 2 comments · Fixed by #566
Closed

Report is generated prior to contrast creation #537

adelavega opened this issue Apr 3, 2019 · 2 comments · Fixed by #566
Projects

Comments

@adelavega
Copy link
Collaborator

This error has been occuring frequenly. My guess is that its due to a variable that is not available for all runs. But if this is the case, we should make a nicer warning with #534

This occurs in wk669 for example

Traceback (most recent call last): File "/usr/local/lib/python3.6/site-packages/celery/app/trace.py", line 382, in trace_task R = retval = fun(*args, **kwargs) File "/usr/local/lib/python3.6/site-packages/celery/app/trace.py", line 641, in __protected_call__ return self.run(*args, **kwargs) File "/celery_worker/tasks.py", line 48, in generate_report analysis, predictor_events, bids_dir, run_ids) File "/celery_worker/compile.py", line 120, in build_analysis bids_analysis.setup(**entities) File "/usr/src/app/src/pybids/bids/analysis/analysis.py", line 89, in setup b.setup(input_nodes, drop_na=drop_na, **selectors) File "/usr/src/app/src/pybids/bids/analysis/analysis.py", line 206, in setup node_coll = self._concatenate_input_nodes(input_nodes) File "/usr/src/app/src/pybids/bids/analysis/analysis.py", line 166, in _concatenate_input_nodes return BIDSVariableCollection.from_df(data, entities, self.level) File "/usr/src/app/src/pybids/bids/variables/kollekshuns.py", line 150, in from_df return BIDSVariableCollection(variables) File "/usr/src/app/src/pybids/bids/variables/kollekshuns.py", line 38, in __init__ raise ValueError("No variables were provided") ValueError: No variables were provided 
@adelavega
Copy link
Collaborator Author

Okay, this problem doesn't seem to replicate that often, so my guess is that sometimes it posts and tries to get a report before contrasts are added in, which would make sense

@adelavega
Copy link
Collaborator Author

Yep, it looks like if you don't add contrasts, and click "Next" , even though it won't let you advance, it still triggers the report, which will fail because it needs at least one contrast.

Changing this to a frontend bug.

@adelavega adelavega added frontend and removed backend labels Apr 3, 2019
@adelavega adelavega changed the title No variables were provided Report is generated prior to contrast creation Apr 3, 2019
@adelavega adelavega added this to To Do (Frontend) in 0.9 via automation May 14, 2019
@adelavega adelavega moved this from To Do (Frontend) to In Progress in 0.9 May 14, 2019
rwblair added a commit that referenced this issue May 14, 2019
…nalysis

function accordingly. Fixes #555

Disable next button on contrast tab if no contrasts present. Never set
flag to generate reports if no contrasts exist. Fixes #537

Have analyses names line break if too long. Fixes #562

Non existant analysis IDs will now redirect to /builder/. Fixes #484

on error codes 400 and above do not attempt to parse response as json, just
return status code so component can figure out what it wants to do.
Fixes #527
0.9 automation moved this from In Progress to Done May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.9
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant