-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ecosystem CI tests #36
Conversation
We ended up switching to an new Deno.Command("npm", {
args: ["add", "starfx@file:../../starfx/npm", "--install-links"]) The examples were originally intended to be @parcel/core: Failed to resolve 'react-dom' from
'/home/runner/work/starfx/starfx/starfx/npm/node_modules/react-redux/es/utils/reactBatchedUpdates.js'
/home/runner/work/starfx/starfx/starfx/npm/node_modules/react-redux/es/utils/reactBatchedUpdates.js:1:41
> 1 | export { unstable_batchedUpdates } from 'react-dom';
> | ^^^^^^^^^^^
@parcel/resolver-default: Cannot find module 'react-dom' I left the symlink option in the script as it may be useful in the future for other repos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.scripts/
-> scripts/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for all your help, this is great!
Motivation
To assist in confirming that the built assets run downstream after publishing, we want to test this in CI against the examples repo.
Approach
Dynamic Branch
Additionally, we added a script that will dynamically pull a branch from the examples repo. If the branch name in the current PR running the workflow matches a branch name in the examples repo, it will pull that instead of the
main
branch. This is to assist in dealing with breaking changes. A PR here and a PR there would allow stepping each forward with a green build.Screenshots
Branch by default
Branch when a match exists