-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate Estimator and Corrector descriptions into MetaResult objects #724
Conversation
I'm not sure how to extract relevant BibTeX references from the appropriate bib file, but I'd love to incorporate that into the MetaResults. UPDATE: It's working now! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
==========================================
+ Coverage 88.85% 89.05% +0.19%
==========================================
Files 39 39
Lines 4405 4603 +198
==========================================
+ Hits 3914 4099 +185
- Misses 491 504 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple small details from me for readability, but otherwise looks good to me!
I've made the requested changes. I realized it might take a bit of effort to append the copyright waiver to the boilerplate in the workflow functions, so I'd rather not add that in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
structurally looks good, just went and fixed the conflicts and added some print statements to the example notebooks
Thanks! |
great work @tsalo! |
Closes #690.
Changes proposed in this pull request:
description
parameter anddescription_
attribute to theMetaResult
class.bibtex_
attribute to the MetaResult class with the references from the description only.To do/open questions: