Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster_threshold option to Diagnostics #777

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

JulioAPeraza
Copy link
Collaborator

Closes None.
This parameter will allow users to remove small clusters from the diagnostics.

Changes proposed in this pull request:

  • Add cluster_threshold option to Diagnostics
  • Small refactoring.

@JulioAPeraza JulioAPeraza added enhancement New feature or request diagnostics Issues/PRs related to the diagnostics module. labels Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (ad09e4f) 88.46% compared to head (74fb1ec) 88.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #777      +/-   ##
==========================================
- Coverage   88.46%   88.46%   -0.01%     
==========================================
  Files          40       40              
  Lines        4761     4758       -3     
==========================================
- Hits         4212     4209       -3     
  Misses        549      549              
Impacted Files Coverage Δ
nimare/diagnostics.py 99.13% <100.00%> (-0.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jdkent jdkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think adding a cluster_threshold argument makes the most sense for right now.

@jdkent jdkent merged commit 8c377e1 into neurostuff:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagnostics Issues/PRs related to the diagnostics module. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants