-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add advanced plots to IBMA report #864
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #864 +/- ##
==========================================
+ Coverage 88.20% 88.27% +0.06%
==========================================
Files 48 48
Lines 6335 6370 +35
==========================================
+ Hits 5588 5623 +35
Misses 747 747 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I had one comment, but that can be done in a separate pull request when that becomes relevant.
key_maps = ( | ||
"z_maps" | ||
if "z_maps" in self.results.estimator.inputs_["raw_data"] | ||
else "beta_maps" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per our conversation, the beta maps by themselves do not make much sense to compare across studies, but that can be a different pull request.
Closes None.
Changes proposed in this pull request: