Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH, FIX] Deploy behind nginx-proxy #24

Merged
merged 19 commits into from
Apr 10, 2021
Merged

[ENH, FIX] Deploy behind nginx-proxy #24

merged 19 commits into from
Apr 10, 2021

Conversation

tyarkoni
Copy link
Contributor

@tyarkoni tyarkoni commented Apr 7, 2021

Patches various config files to get the app to play nicely when served alongside other apps behind nginx-proxy. I also took the opportunity to rename neurostuff to neurostore everywhere (should probably have done that in a separate PR, sorry).

@jdkent I have not tested the development environment locally after these changes, and suspect I might have broken something. Mind taking a look?

@tyarkoni tyarkoni requested a review from jdkent April 7, 2021 21:13
@jdkent
Copy link
Member

jdkent commented Apr 9, 2021

I submitted a review as a pull request in #25

@jdkent
Copy link
Member

jdkent commented Apr 10, 2021

Got the workflow working locally and on github actions, so I think this is mergeable.

@jdkent jdkent merged commit f827c89 into master Apr 10, 2021
@jdkent jdkent deleted the proxy-config branch February 27, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants