Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses CORS in local enviroment as well #137

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Uses CORS in local enviroment as well #137

merged 1 commit into from
Oct 12, 2021

Conversation

jschirrmacher
Copy link
Contributor

Previously, we only used CORS in production, because server and client are on different domains.
With this change, CORS is also used locally, enabling us to actually use a local server to store game results which failed due to missing CORS

@barecheck
Copy link

barecheck bot commented Oct 12, 2021

Barecheck - Code coverage report

Total: 71.84%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
src/server.ts6-9, 11-20

Copy link
Collaborator

@mdrie mdrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, what CORS is about, but makes sense, to allow everything when not in production. ;-)

@mdrie mdrie merged commit 148d57e into main Oct 12, 2021
@mdrie mdrie deleted the local-cors branch October 12, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants