-
Notifications
You must be signed in to change notification settings - Fork 213
ReferenceError after upgrading dependencies #984
Comments
Googling the error message returns MatAtBread/fast-async#23. I suspect your lockfile contains out of date dependencies - could you remove it and regenerate? (I'd recommend regenerating it on a schedule using something like https://renovatebot.com/) |
Refreshing the lockfile doesn't fix it for me. Looking closer. |
This reproduces for me using Neutrino 8.0.18 (ie even without the 8.3.0 upgrade), after just refreshing the lockfile. ie:
"resolutions": {
"@neutrinojs/airbnb-base": "8.0.18",
"@neutrinojs/banner": "8.0.18",
"@neutrinojs/clean": "8.0.18",
"@neutrinojs/compile-loader": "8.0.18",
"@neutrinojs/copy": "8.0.18",
"@neutrinojs/eslint": "8.0.18",
"@neutrinojs/hot": "8.0.18",
"@neutrinojs/loader-merge": "8.0.18",
"@neutrinojs/mocha": "8.0.18",
"@neutrinojs/node": "8.0.18",
"@neutrinojs/start-server": "8.0.18",
"neutrino": "8.0.18"
},
As such, it seems like a non-Neutrino in-range subdependency update is what is causing the breakage here, and not Neutrino itself. |
Ok, so the error goes away if I comment out the Also, when I disable the usage of fast-async, the error no longer occurs: [
'@neutrinojs/node',
{
polyfills: {
async: false,
},
// ...
] So it looks like a in-semver-range update of either fast-async or one of the babel packages causes the construct above to now fail. To work around, you can disable the fast-async babel plugin per the above. So long as you're using Node 8+ (or a recent browser) you don't actually need any transformation of async, since it's supported natively (which is why #790 removes our use of it for Neutrino 9). |
Thanks for looking into it! |
I've created a reduced testcase and opened MatAtBread/fast-async#58. This appears to be a regression in |
Bug
Please try to answer the following questions:
I've pushed a branch to my repo which you can use to reproduce:
https://github.com/armenzg/firefox-health-backend/tree/neutrino
I'm happy to wait for version 9 rather than upgrading now.
The text was updated successfully, but these errors were encountered: