Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please help with documentation #2197

Closed
clarsen-007 opened this issue Mar 28, 2022 · 3 comments
Closed

Please help with documentation #2197

clarsen-007 opened this issue Mar 28, 2022 · 3 comments
Labels

Comments

@clarsen-007
Copy link

I think I might be reading documentation wrong.
In sesman.ini - If MaxLoginRetry is set to 1 - then another login attempt should not be allowed.

So I only want one login attempt, and then session should disconnect.
Do not want users to be able to have multiple Login attempt.

Is this the correct config?

Currently it shows Login screen - if you enter incorrect details then is shows the "... login failed for display 0", and if you click on "OK" button it goes back to Login screen and prompt.
Should it not disconnect if MaxLoginRetry is set?

Ubuntu 20.04

@metalefty metalefty added the docs label Mar 28, 2022
@metalefty
Copy link
Member

I don't get you.

MaxLoginRetry do not control disconnection. Why do you think it SHOULD disconnect?

@metalefty
Copy link
Member

For the record, MaxLoginRetry finally checked here. It is SCPv1 stuff.

https://github.com/neutrinolabs/xrdp/blob/v0.9.19/sesman/scp_v1.c#L59-L94

And this is the documented behaviour. Login attempts more than MaxLoginRetry is not allowed.

       MaxLoginRetry=number
              The number of login attempts that are allowed on terminal
              server. If set to 0, unlimited attempts are allowed. If not
              specified, defaults to 3.

BTW, we are reworking authentication now. So MaxLoginRetry takes no effect with the current HEAD (will be reintroduced in near future).

@matt335672
Copy link
Member

Duplicate of #1739

I'll close this for now - we are aware of it @clarsen-007 but thanks for engaging with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants