Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused envs from readme.md #88

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Anmol1696
Copy link
Contributor

Overview

From the struct of the TargetChainConfig, both AccountPrefix and ValidatorAccountPrefix dont seme to be used anymore.
Since it is still present in the readme, it is a little confusing for the setup.

Copy link
Contributor

@NeverHappened NeverHappened left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Copy link
Contributor

@foxpy foxpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we removed these options but forgot to update the README.

@Anmol1696
Copy link
Contributor Author

Is there anything else I can do to get the CI working and get the PR merged?

@NeverHappened
Copy link
Contributor

NeverHappened commented Apr 6, 2024

@Anmol1696
#88 (comment)
No, we'll merge it soon, big thanks for the help!

@pr0n00gler pr0n00gler merged commit 6da0eb9 into neutron-org:main Apr 8, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants