Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/dynamic fees #91

Merged
merged 15 commits into from
Jul 6, 2024
Merged

Feat/dynamic fees #91

merged 15 commits into from
Jul 6, 2024

Conversation

quasisamurai
Copy link
Contributor

@quasisamurai quasisamurai commented Jun 11, 2024 •
edited
Loading

ICQ relayer must support dynamic gas prices via feemarket so we implemented this behavior:

  • Gas prices by default always queried from feemarket
  • If query fails for some reason -> relayer uses default gp from config

Also two additional env vars introduced:

  • GAS_MULTIPLIER: multiplies queried/default GP by given coeff (basically a tips for validators)
  • MAX_GAS: if queried & previously multiplied gas exceeds this limit, set gas equal to this limit.

int tests pr
neutron-org/neutron-integration-tests#325

@quasisamurai
go mod tidy
5c6b50d 
toolchain

upd neutron dep

query dynamic price for tx submission
@pr0n00gler pr0n00gler marked this pull request as ready for review June 14, 2024 10:10
@quasisamurai
Copy link
Contributor Author

https://github.com/neutron-org/neutron-tests/actions/runs/9582405898/job/26428850191

swelf19
swelf19 reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@swelf19 swelf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's set default gas price with a really low value in integration tests to see if dynamic prices really works

internal/submit/tx_sender.go Outdated Show resolved Hide resolved
internal/submit/tx_sender.go Show resolved Hide resolved
internal/submit/tx_sender.go Outdated Show resolved Hide resolved
joldie777
joldie777 previously approved these changes Jun 24, 2024
View reviewed changes
@pr0n00gler pr0n00gler requested a review from swelf19 June 25, 2024 14:24
swelf19
swelf19 previously approved these changes Jun 28, 2024
View reviewed changes
@joldie777 joldie777 force-pushed the feat/sdk-50 branch 2 times, most recently from e765e5a to ed4cbc7 Compare June 28, 2024 12:25
@pr0n00gler pr0n00gler changed the base branch from feat/sdk-50 to main July 1, 2024 13:30
@pr0n00gler pr0n00gler dismissed stale reviews from swelf19 and joldie777 July 1, 2024 13:30

The base branch was changed.

@pr0n00gler
Copy link
Collaborator

Please, resolve conflicts

@quasisamurai
Copy link
Contributor Author

https://github.com/neutron-org/neutron-tests/actions/runs/9798300917

@quasisamurai quasisamurai mentioned this pull request Jul 5, 2024
Merged
@pr0n00gler pr0n00gler merged commit 3007fd7 into main Jul 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joldie777 joldie777 joldie777 approved these changes

@pr0n00gler pr0n00gler pr0n00gler approved these changes

@swelf19 swelf19 swelf19 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quasisamurai @pr0n00gler @joldie777 @swelf19