-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce two samples #91
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #91 +/- ##
==========================================
+ Coverage 58.57% 60.81% +2.23%
==========================================
Files 33 33
Lines 6330 6535 +205
==========================================
+ Hits 3708 3974 +266
+ Misses 2622 2561 -61 ☔ View full report in Codecov by Sentry. |
backmari
force-pushed
the
reduce_two_samples
branch
from
August 5, 2024 15:03
98a5745
to
a1b9fdc
Compare
backmari
force-pushed
the
reduce_two_samples
branch
3 times, most recently
from
September 17, 2024 16:01
30f7148
to
f2d36db
Compare
…operty that points to the active reduction list.
backmari
force-pushed
the
reduce_two_samples
branch
from
October 25, 2024 13:13
2c0def8
to
58dc933
Compare
- fix wrong data plotted when loading reduced data with multiple peaks - fix error thrown when removing the active run from a data tab - fix additional data tabs not cleared when reloading reduced data file - fix additional data tabs not cleared when pressing button "Remove all data sets from the reduction list" and changed tool tip text
jmborr
reviewed
Oct 28, 2024
jmborr
requested changes
Oct 29, 2024
jmborr
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes:
This change makes it possible to select multiple regions of interest in the same run and reduce them together. At MagRef it is common to have more than one sample per run, and this change makes it easier to reduce the data from such runs.
Users can add additional reduction tables by clicking the button with a "+" sign. This copies the runs from the first (main) reduction table. By selecting another reduction table "Data (ROI 2)" and adjusting the region of interest, the user can see the reflectivity curve for that sample. When the user clicks the button "Reduce..." and confirms the reduction options, each reduction table is reduced and reduced files are written.
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
Reduced data file with multiple peaks (need to remove .txt file extension):
REF_M_manual_test_multiple_peaks.dat.txt
References
Story 1233: [QUICKNXS] Add the capability to reduce two samples from the same run