Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement sidebars on react pages #1957
Implement sidebars on react pages #1957
Changes from 22 commits
0dfa261
834f667
9bcb203
7b6c2a2
1cc9ee5
e62ce1a
0883ecf
9a56a97
981c8c0
c0ae88c
ee64114
64ee3a5
c561b4c
6b7a45d
1614a85
40953cd
356b329
395bfdb
82a29f9
a2da7b8
5046172
32253a0
c544af2
46a50e0
8775607
86e4207
8bd9a24
b8b548b
7664cb3
ef8ad72
39a4224
cb11ebd
eef8acb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another nitpick that doesn't require changing: Number|String is more commonly used. Technically in a type annotation like this it would be
number|string
since Number and String refer to the boxed versions of the primitive number and string types.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, all of the JSDoc—actually, most of the green code here—was copy-paste :D That did look odd though.