Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One Click Reblog doesn't give room to write #61

Closed
hobinjk opened this issue Jul 30, 2015 · 4 comments
Closed

One Click Reblog doesn't give room to write #61

hobinjk opened this issue Jul 30, 2015 · 4 comments
Labels

Comments

@hobinjk
Copy link

hobinjk commented Jul 30, 2015

When selecting the open in new tab option the composition window that opens does not have a space to write in, forcing the user to mess with the editor to create it.

@hobinjk hobinjk added the bug label Jul 30, 2015
@realityfabric
Copy link

I could be wrong, I don't know jQuery so I couldn't follow everything that was going on, but could this be a problem with strip_sentence?
Line 1213:
m_sentence = m_sentence.replace("<p></p>","");

@hobinjk
Copy link
Author

hobinjk commented Jul 31, 2015

@realityfabric That seems like a logical explanation. If you want to test it, go to http://tumblr.com/xkit_editor (it's really nice in Firefox) and open one_click_reblog. There's also more information here.

@realityfabric
Copy link

Well, it doesn't look like that was it, I completely removed that line and nothing changed.

@hobinjk
Copy link
Author

hobinjk commented Jul 31, 2015

Hmm, that's too bad. I'll try a less elegant fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants