Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One Click Reblog Not Working #76

Closed
rhirps opened this issue Jul 31, 2015 · 38 comments
Closed

One Click Reblog Not Working #76

rhirps opened this issue Jul 31, 2015 · 38 comments

Comments

@rhirps
Copy link

rhirps commented Jul 31, 2015

I hover over the reblog button and the screen pops up but when I click the reblog button there all I get is a continuous loading symbol. It won't reblog anything.

@NursePhantump
Copy link

Have you uninstalled the old x-kit? If not be sure to do so and that should fix the problem!

@eggkin
Copy link

eggkin commented Jul 31, 2015

I'm having this problem too, but I've already uninstalled the old xkit and that didn't fix it. I even restarted my entire browser.
Windows 10, chrome.

@Zarggg
Copy link

Zarggg commented Jul 31, 2015

I've also noticed this, but haven't been paying close enough attention to what I was doing just before it happens.
Windows 10, Firefox.

@meiloslyther
Copy link

Having the same problem, even after uninstalling the old xkit. Windows 7, Chrome.

@dlmarquis
Copy link

Could be a cache problem. Have you tried clearing the cache?

@eggkin
Copy link

eggkin commented Aug 1, 2015

Just tried that, restarted browser too, didn't work :/
Maybe it's a windows 10 thing for me? I don't quite know how this stuff works, and I only discovered the new xkit the day after I updated so I dont have any previous knowledge on how it was working.

@rhirps
Copy link
Author

rhirps commented Aug 1, 2015

I have uninstalled the old xkit. Windows 8.1, Chrome. I cleared the chache and it still didn't work. /:

@ceksie
Copy link

ceksie commented Aug 1, 2015

i'm on a mac and using chrome and it doesnt work for me either

@nightpool
Copy link
Member

can you guys post your xkit and one-click-postage versions?
image
image

@nightpool
Copy link
Member

Also, a list of the extensions you have installed would be helpful.

@rhirps
Copy link
Author

rhirps commented Aug 1, 2015

screenshot 15
screenshot 16
xinbox, one click postage, one click reply, tweaks, go to das, activity+, anti-capitalism, auto load images, audio downloader, auto tagger, blacklist, classic search, convert links, drafts+, enhanced queue, mass+, mass deleter, no recommended, notification block, notifications+, outbox, post block, quick tags, read more now, reblog as text, reply viewer, reblog yourself, search likes, tag replacer, timestamps, open in tabs, editable reblogs

@eggkin
Copy link

eggkin commented Aug 1, 2015

Xkit: 7.6.5
One-click postage: 4.0.0
extensions: all the default ones, timestamps, xcloud, tags on sidebar, classic search, reblog yourself, read more now, reblog as text, outbox, drafts+, convert links, blacklist, color quotes, search likes, servant, auto load images, tag replacer, find inactive, separator, view my tags, audio+, notifications+, access kit, open in tabs, mass+, activity+, Xwidgets, profiler, mass deleter, user menus, xstats, view on dash, tagviewer, autotagger, quick tags, enhanced queue, post block, jk across pages, notification block, post archiver, limit people, reply viewer, retags, no recommended, no sidebar, soft refresh, show originals, anti-capitalism, editable reblogs, header options, lethe

some of those I have disabled, however, but those are all the ones installed
(disabled: tags on sidebar, classic search, separator, access kit, activity+, view on dash, quick tags, jk across pages, limit people, soft refresh, show originals, header options, lethe)

@meiloslyther
Copy link

xkit: 7.6.5
One-click postage: 4.0.0
extensions: xinbox, one-click postage, one-click reply, tweaks, go-to-dash, anti-capitalism, blacklist, audio downloader, auto load images, auto tagger, color quotes, convert links, enhanced queue, no recommended, no sidebar, open in tabs, outbox, profiler, user menus+, quick tags, read more now, reblog as text, reply viewer, retags, tag viewer, timestamps, view on dash, estufar's sidebar fix

@nightpool
Copy link
Member

okay these are the extensions you guys all share:

'anti-capitalism', 'auto tagger', 'blacklist', 'convert links', 'editable reblogs',
'enhanced queue', 'no recommended', 'one click postage', 'open in tabs',
'outbox', 'read more now', 'reblog as text', 'reply viewer'

I'll take a look and see if I can reproduce this.

@nightpool
Copy link
Member

Okay so just to confirm: for all of you guys, the reblog button won't ever stop the loading animation?

@ceksie
Copy link

ceksie commented Aug 1, 2015

nope

@ceksie
Copy link

ceksie commented Aug 1, 2015

at least not as long as i've waited?

@rhirps
Copy link
Author

rhirps commented Aug 1, 2015

Yes, it won't stop loading.

@eggkin
Copy link

eggkin commented Aug 1, 2015

like, I get the menu to pop up, hit reblog, and the loading symbol doesnt go away, so yeah.

@rhirps
Copy link
Author

rhirps commented Aug 1, 2015

Yeah same as eggkin but it doesn't reblog the post at all.

@eggkin
Copy link

eggkin commented Aug 1, 2015

Yeah, rhirps, that's what I mean, it doesn't reblog, it is eternally trying to process the request.

@hobinjk
Copy link

hobinjk commented Aug 1, 2015

"Not loading" is usually the result of an error being encountered in the API call that sends the post. This may be due to a change in protocol accompanying the Tumblr update

@rhirps
Copy link
Author

rhirps commented Aug 1, 2015

This problem has been going on since before the update with me.

@meiloslyther
Copy link

I'm not sure what update you mean, hobinjk, but this has been going on for at least a week for me, maybe two.

@nightpool
Copy link
Member

okay I still can't reproduce this, but here's a modified version of one_click_postage that should give us more information about what problem's you're running into:

https://gist.githubusercontent.com/nightpool/aa763df7f1b700e837fd/raw/56b5d9c8196145d06c3ff2747cd84a953d09832b/one_click_postage.js

  • open the document, press ctrl-a and then copy
  • open up tumblr.com/xkit_editor
  • open extension -> one click postage
  • ctrl-a, paste
  • open a new tumblr dashboard, try to reblog a post
  • an error window should pop up. Copy and paste the error you get.

unfortunately this is kludgy, but its the only way we have of figuring out what's going on now.

@ceksie
Copy link

ceksie commented Aug 1, 2015

for me it's still loading like it was before

@nightpool
Copy link
Member

@hobinjk i dunno, the onerror handlers for those calls are pretty well populated. there aren't many places that aren't covered by a try/catch block.

@nightpool
Copy link
Member

@ceksie if you open up the developer console, (cmd-alt-j) do you see any red errors?

EDIT:you have to be on the tumblr dashboard to see the errors for it.

@ceksie
Copy link

ceksie commented Aug 1, 2015

yes lots i'll get a pic

@ceksie
Copy link

ceksie commented Aug 1, 2015

@eggkin
Copy link

eggkin commented Aug 1, 2015

The edit didn't work for me, I am still getting the same problem.

@nightpool
Copy link
Member

Found it! this is a problem with autotagger, but only if you've enabled "replace dashes in the username with spaces"

disable this option for now, and then we'll have a fix out soon that will allow you to re-enable it.

@ceksie
Copy link

ceksie commented Aug 1, 2015

works now, thanks!

@eggkin
Copy link

eggkin commented Aug 1, 2015

Works wonderfully now, with that disabled, thanks!

@nightpool
Copy link
Member

@hobinjk do we have a translation layer between the returned 'svc/post' models and xkit.interfaces.post objects? it looks like the code assumes they're going to be the same thing. (which is bad for us if tumblr changes any of their API)

@nightpool nightpool mentioned this issue Aug 1, 2015
@hobinjk
Copy link

hobinjk commented Aug 1, 2015

@nightpool No, if I remember correctly the XKit.interface.post objects are only generated by scraping the ".post" elements whereas svc/post/* can do whatever it wants to. It would definitely be worthwhile to create XKit.interface.post.delete, XKit.interface.post.update, and XKit.interface.post.fetch. The main reason that hasn't already happened is that the object that the svc/post/* methods use is really poorly documented and changes significantly based on what it represents.

@hobinjk
Copy link

hobinjk commented Aug 4, 2015

Closing because this hopefully works now.

@hobinjk hobinjk closed this as completed Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants