Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim USB interface before doing bulk reads #12

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

nitroxis
Copy link

@nitroxis nitroxis commented Jul 5, 2021

This fixes an issue I encounter with this library on Windows where read_bulk would always return an error in rx. After some troubleshooting I found that one apparently should call claim_interface and release_interface, though I have no experience with libusb. However, it works flawlessly now.

@nitroxis
Copy link
Author

nitroxis commented Jul 5, 2021

This PR might actually fix #9, it looks similar to what I was experiencing.

Copy link
Owner

@newAM newAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The changes look good, sorry I missed this.

I will test it out with a physical device when I have time (likely not until the weekend) and merge it in then.

@newAM newAM merged commit ee4f808 into newAM:main Jul 6, 2021
@newAM newAM mentioned this pull request Jul 6, 2021
@newAM
Copy link
Owner

newAM commented Jul 6, 2021

Tested & merged.

v0.2.1 includes the changes here. Thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants