-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed not stopping when moving; Fixed interrupted moving #409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am noticing a lot of hysteresis after these changes.
It is probably something small, but work is keeping me busy these days and I might not have time to debug for a while.
main
branch, high to low:
$ poetry run idasen height
0.798 meters
$ poetry run idasen sit
$ poetry run idasen height
0.740 meters
main
branch, low to high:
$ poetry run idasen height
0.678 meters
$ poetry run idasen sit
$ poetry run idasen height
0.740 meters
#409, high to low:
$ poetry run idasen height
0.794 meters
$ poetry run idasen sit
$ poetry run idasen height
0.783 meters
#409, low to high:
$ poetry run idasen height
0.683 meters
$ poetry run idasen sit
$ poetry run idasen height
0.694 meters
I will have a look at what is causing this. |
… because of sleep
8ffb7ac
to
ce486ca
Compare
Ok, it turned out the delay was still needed when running locally, less so when running via a Bluetooth proxy on esphome. Lowering the delay actually seems to have solved the issues I have seeing. Re-adding the delay also solved the hysteresis. I think it should be good to go now. |
v0.11.1 introduces some regressions as reported in: home-assistant/core#110958 newAM/idasen#409
v0.11.1 introduces some regressions as reported in: home-assistant/core#110958 newAM/idasen#409
v0.11.1 introduces some regressions as reported in: home-assistant/core#110958 newAM/idasen#409
If you have time to test it with your desk, it would be nice to get this through, idasen-ha was already updated to downgrade to 0.11: home-assistant/core#110958, abmantis/idasen-ha#23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
newAM/idasen#409 got merged, so the version can be bumped to 0.12.0 again. This improves the height changes quite a bit, it will not overshoot or undershoot anymore, but always stop exactly at the requested height (same as with the IKEA app). Also speed got added, so once the version is updated, this can also be added as a sensor to HA.
After my PR #396 I noticed that my desk is not stopping anymore if pressing stop in Home Assistant. The moving of the desk is also sometimes interrupted. These changes fix these issues, I tested it with Home Assistant and everything seems to be working smoothly again.
I had a local implementation for my own desk which I was using before and the sleep was necessary, but it does not seem to be necessary with the Bleak Bluetooth library.