Show text of selected non-truthy items #199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks a lot for this project!
When adding a SelectOption Interface with an item whose value is non-truthy (for example 0), this option's text should be shown when it is selected.
An example that I would like to use is this:
Currently, when selecting "off", the
this.value
is 0, which is not truthy, so "" is shown as the selected value instead of "off".With my change, we always try to get the corresponding text from the items list. If
value
is set to an option that is not inthe list of options,
getItemByValue
will return undefined, which will be converted to an empty string, as it was before.