-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Verify 'Yith Wonder' Theme Activation in Preview & Editor Step #523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the issue that is happening is expediteInstall is called and that installs and activates the yith theme and does a refresh of the same,
and when that happens component loads again and useEffect
is called that listens on storedThemeStatus
as storedThemeStatus = init
and handleThemeStatus is called and that reloads if theme was active due to which this useEffect cycle continues forever.
Looking for a fix and trying that.
Onboarding Data PR: newfold-labs/wp-module-onboarding-data#67 |
|
if I applied a new font, it is still selecting the first font-pair from the Customize panel. |
This pull request enhances the Preview Step in the SiteGen flow by introducing code to verify and ensure that the activated theme is 'Yith Wonder.' This addition aims to improve the reliability and consistency of the site generation process, ensuring that the correct theme is active during the preview.