Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Verify 'Yith Wonder' Theme Activation in Preview & Editor Step #523

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

mr-vara
Copy link
Contributor

@mr-vara mr-vara commented Mar 19, 2024

This pull request enhances the Preview Step in the SiteGen flow by introducing code to verify and ensure that the activated theme is 'Yith Wonder.' This addition aims to improve the reliability and consistency of the site generation process, ensuring that the correct theme is active during the preview.

@mr-vara mr-vara changed the title Enhancement: Verify 'Yith Wonder' Theme Activation in Preview Step Enhancement: Verify 'Yith Wonder' Theme Activation in Preview & Editor Step Mar 19, 2024
@arunshenoy99 arunshenoy99 added the WIP PR is a Work in Progress and not ready for review. label Mar 27, 2024
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the issue that is happening is expediteInstall is called and that installs and activates the yith theme and does a refresh of the same,
and when that happens component loads again and useEffect is called that listens on storedThemeStatus as storedThemeStatus = init and handleThemeStatus is called and that reloads if theme was active due to which this useEffect cycle continues forever.

Looking for a fix and trying that.

@officiallygod
Copy link
Member

Onboarding Data PR: newfold-labs/wp-module-onboarding-data#67

@officiallygod officiallygod added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels Apr 3, 2024
@arunshenoy99 arunshenoy99 added QA This PR is in QA and removed Code Review The PR is in Code Review labels Apr 8, 2024
@girish-lokapure
Copy link
Contributor

girish-lokapure commented Apr 8, 2024

  • The previous flow continues to function as expected.
  • In the AI site generation flow, the YITH wonder is installed and activated. However, when customizing the color and typography, the typography changes are not applied.

@ajayadav09
Copy link
Contributor

  • The previous flow continues to function as expected.
  • In the AI site generation flow, the YITH wonder is installed and activated. However, when customizing the color and typography, the typography changes are not applied.

if I applied a new font, it is still selecting the first font-pair from the Customize panel.

@arunshenoy99 arunshenoy99 added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Apr 8, 2024
@arunshenoy99 arunshenoy99 merged commit 8f649e6 into trunk Apr 8, 2024
5 of 7 checks passed
@arunshenoy99 arunshenoy99 deleted the add-theme-expedite-for-sitegen branch April 8, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants