Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mocking AI sitegen and homepage APIs in site-logo step #529

Merged
merged 25 commits into from
Apr 4, 2024
Merged

Mocking AI sitegen and homepage APIs in site-logo step #529

merged 25 commits into from
Apr 4, 2024

Conversation

sangeetha-nayak
Copy link
Contributor

Proposed changes

PRESS2-1866 Mocking all sitegen and homepages APIs using cypress functionalities in order to stop actual hits to open AI by stubbing all calls with valid static response.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Test enhancement
api-mock-final.mp4

@sangeetha-nayak sangeetha-nayak added the WIP PR is a Work in Progress and not ready for review. label Mar 29, 2024
@sangeetha-nayak sangeetha-nayak added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels Mar 29, 2024
officiallygod
officiallygod approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me!

@sangeetha-nayak sangeetha-nayak added Ready to merge The Code Review and QA is done and it can be merged. and removed Code Review The PR is in Code Review labels Apr 3, 2024
@sangeetha-nayak sangeetha-nayak merged commit bf86dbe into trunk Apr 4, 2024
1 of 4 checks passed
@avneet-raj avneet-raj deleted the test/mock-api branch April 4, 2024 13:13
@officiallygod officiallygod restored the test/mock-api branch April 9, 2024 12:00
@officiallygod officiallygod deleted the test/mock-api branch July 25, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod approved these changes

@arunshenoy99 arunshenoy99 Awaiting requested review from arunshenoy99

Assignees
No one assigned
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sangeetha-nayak @officiallygod @avneet-raj