Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESS0-1329 | Cypress tests for Migration initiation screen #561

Merged
merged 17 commits into from
May 14, 2024

Conversation

sangeetha-nayak
Copy link
Contributor

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@sangeetha-nayak sangeetha-nayak added the WIP PR is a Work in Progress and not ready for review. label May 10, 2024
@sangeetha-nayak sangeetha-nayak added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels May 13, 2024
Copy link
Contributor

@ajayadav09 ajayadav09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@@ -11,6 +11,7 @@ const homepages_mock = require( '../../fixtures/homepages.json' );
const theme_style_mock = require( '../../fixtures/theme-style.json' );
const customize_data_mock = require( '../../fixtures/customize-data.json' );
const homepage_regenerate_mock = require( '../../fixtures/homepage-regenerate.json' );
const migate_connect_mock = require( '../../fixtures/migrate-connect.json' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you could change it to *migrate_connect_mock

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sangeetha-nayak sangeetha-nayak added Ready to merge The Code Review and QA is done and it can be merged. and removed Code Review The PR is in Code Review labels May 14, 2024
@sangeetha-nayak sangeetha-nayak merged commit 33db773 into trunk May 14, 2024
3 of 4 checks passed
@sangeetha-nayak sangeetha-nayak deleted the add/migration-screen/tests branch May 14, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants